Skip to content

Conversation

@im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Sep 3, 2025

What?

Closes #71478

Removes unnecessary flex-direction CSS rules for RTL languages in the Accordion Header toggle button.

Why?

Flexbox automatically handles RTL positioning. The manual flex-direction overrides cause incorrect text/icon layout in RTL languages.

How?

Removes RTL CSS rules in packages/block-library/src/accordion/style.scss.

Testing Instructions

  1. Switch to RTL language (Arabic/Hebrew)
  2. Insert Accordion block
  3. Verify toggle button text and icon position correctly
  4. Test both default and icon-position-left variants

Screencast

image

@im3dabasia im3dabasia marked this pull request as ready for review September 3, 2025 08:44
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

P.S. I'm sure you can add labels to issues or PR, so feel free to add appropriate labels when you submit a PR. Also, feel free to merge your approved PRs 👍

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts [Block] Accordion Affects the Accordion Block labels Sep 3, 2025
@im3dabasia im3dabasia merged commit 4653a30 into WordPress:trunk Sep 3, 2025
79 of 82 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.6 milestone Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Accordion Affects the Accordion Block Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accordion Header: Toggle button text and icon have incorrect layout in RTL languages

2 participants