[Block] Cover: Fix resize handler gets stuck on undo #70820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, Why, and How?
Closes #70819
This PR fixes a bug where the resize handler doesn't reset correctly after the first undo following a
Coverblock resize.This occurs because the following line only checks whether
minHeightUnitis set topx.Ref:
gutenberg/packages/block-library/src/cover/edit/index.js
Line 327 in 2a278af
After resizing and undoing, the unit may still be
px, butminHeightbecomesundefined. In this case, theresizableBoxheight should default toauto.Ref. of a similar condition:
gutenberg/packages/block-library/src/cover/edit/index.js
Lines 332 to 335 in 2a278af
Testing Instructions
CMD/CTRL + Z.Testing Instructions for Keyboard
Same.
Screenshots