-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Migrate redux-routine package to TS
#70686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate redux-routine package to TS
#70686
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| * | ||
| * @return Whether object is an action. | ||
| */ | ||
| export function isAction( object: any ): object is AnyAction { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us use unknown instead of any here.
| export function isAction( object: any ): object is AnyAction { | |
| export function isAction( object: unknown ): object is Action { |
We may need to add this to a types.ts file in the same directory
/**
* Add type guard for isPlainObject until the below PR gets merged:
*
* @see https://github.com/jonschlinkert/is-plain-object/pull/29
*/
declare module 'is-plain-object' {
export function isPlainObject(
value: unknown
): value is Record< PropertyKey, unknown >;
}
manzoorwanijk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now. Thank you for making the changes.
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>
What?
Part of: #67691
Migrating the redux-routine package to Typescript.
Why?
Type safety.
Testing Instructions
Type check and unit tests