Skip to content

Conversation

@Soean
Copy link
Member

@Soean Soean commented Nov 19, 2024

What?

Removes old backward compatibility code for WordPress < 6.4 in the pattern render function.

was added in #54651

Why?

The minimum is WordPress 6.5, so we don't need this code anymore

@Soean Soean added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 19, 2024
@Soean Soean requested a review from gziolo November 19, 2024 19:09
@Soean Soean requested a review from ajitbohra as a code owner November 19, 2024 19:09
@github-actions
Copy link

github-actions bot commented Nov 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Soean <soean@git.wordpress.org>
Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka requested a review from ockham November 20, 2024 08:29
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 👍

@Soean Soean merged commit b08c774 into trunk Nov 20, 2024
70 checks passed
@Soean Soean deleted the wp_6_4_backward_compatibility branch November 20, 2024 09:21
@github-actions github-actions bot added this to the Gutenberg 19.8 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants