fix: Set empty default block settings value
#64448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
Currently, `__experimentalFeatures` is only partially implemented for the native mobile editor. Recent changes to the shared Gallery block component included a reference to this missing key via the `useSettings` Hook. Setting a default, empty value ensure exceptions are not thrown.
5a8c659 to
2405f11
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 2405f11. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10355407804
|
Member
|
Thank you @dcalhoun for the PR. Really appreciate your help. |
akasunil
added a commit
that referenced
this pull request
Oct 22, 2024
* Add link control as toolbar option in gallery * Add link option constant for lightbox * Add expand on lick option in link control * Add class into menugroup component for info text style * Add styles for info text in link control of popover of gallery block * Add info text for lightbox option in link control for gallery block * Add action for lightbox option in gallery block link control * Show lightbox option only when lightbox UI is enabled * Disable lightbox when other link option is selected in gallery block * Remove unneccessory constant * Conditionally apply the lightbox attribute based on defatult setting * Fix lightbox default option issue for gallery block on page load * Highlight link to option in gallery block when selected * update condition to Highlight link to option * Fix lightbox attribute issue for default state of linkTo option * fix: Set empty default `block` settings value (#64448) Currently, `__experimentalFeatures` is only partially implemented for the native mobile editor. Recent changes to the shared Gallery block component included a reference to this missing key via the `useSettings` Hook. Setting a default, empty value ensure exceptions are not thrown. Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org> Co-authored-by: akasunil <sunil25393@git.wordpress.org> * Change lightbox option lable and address other feedback * Move lightbox logic to getHrefAndDestination function * Remove highlight of LinkTo option in gallery block * Remove css for info text of lightbox option * Refactor getHrefAndDestination function to for lightbox additional attributes --------- Co-authored-by: akasunil <sunil25393@git.wordpress.org> Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Add link control as toolbar option in gallery * Add link option constant for lightbox * Add expand on lick option in link control * Add class into menugroup component for info text style * Add styles for info text in link control of popover of gallery block * Add info text for lightbox option in link control for gallery block * Add action for lightbox option in gallery block link control * Show lightbox option only when lightbox UI is enabled * Disable lightbox when other link option is selected in gallery block * Remove unneccessory constant * Conditionally apply the lightbox attribute based on defatult setting * Fix lightbox default option issue for gallery block on page load * Highlight link to option in gallery block when selected * update condition to Highlight link to option * Fix lightbox attribute issue for default state of linkTo option * fix: Set empty default `block` settings value (WordPress#64448) Currently, `__experimentalFeatures` is only partially implemented for the native mobile editor. Recent changes to the shared Gallery block component included a reference to this missing key via the `useSettings` Hook. Setting a default, empty value ensure exceptions are not thrown. Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org> Co-authored-by: akasunil <sunil25393@git.wordpress.org> * Change lightbox option lable and address other feedback * Move lightbox logic to getHrefAndDestination function * Remove highlight of LinkTo option in gallery block * Remove css for info text of lightbox option * Refactor getHrefAndDestination function to for lightbox additional attributes --------- Co-authored-by: akasunil <sunil25393@git.wordpress.org> Co-authored-by: dcalhoun <dpcalhoun@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prevent native mobile editor exceptions thrown within the Gallery block
component, which is shared between web and native mobile.
Why?
Currently,
__experimentalFeaturesis only partially implemented forthe native mobile editor. Recent changes to the shared Gallery block
component included a reference to this missing key via the
useSettingsHook. Setting a default, empty value ensure exceptions are not thrown.
How?
Set an empty, default value for
__experimentalFeatures.blocks.Testing Instructions
Testing Instructions for Keyboard
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.