Add README to the useSetting component #53162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm am not able to add the developer-documentation label to this PR unfortunately that would resolve the above problem. |
Contributor
@ingeniumed label has been added. Thanks a lot for working on this issue |
Contributor
Author
|
Thanks for approving it! You would need to merge it in as well, as I don't have permission to merge it unfortunately. |
Contributor
|
Merged |
Contributor
Author
|
@mburridge - I think you closed the PR instead of merging it in. Would be able to re-open and merge it in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This will add a README for the useSetting component, with relevant details and examples of usage.
Why?
This will resolve #52079
How?
The README is what's needed to resolve that issue.
Testing Instructions
N/A
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A