Page actions: 'Move to trash' -> 'Trash'

[jameskoster]

Now that we're displaying text buttons rather than icon buttons we should optimise label lengths where possible to save space. One potential example could be shortening 'Move to trash' to just 'Trash' (assuming this still works from an i18n perspective).

[simison]

Should we allow a different label in row vs dropdown? “View” vs “View response” as an example.

[jorgefilipecosta]

Hi @jameskoster I submitted a PR at #72596.

[hanneslsm]

I think we should add a note for the translators that Trash in that case is meant to be a verb, synonym for "delete".
For example in German, I can only think of it to translate to löschen or entfernen, which actually is delete or remove.

Which begs the question, why not using delete also in english, because it's more common and easier to understand than a single trash command? What do you think?

[jameskoster]

@hanneslsm because trash and delete are different concepts. For the i18n aspect, maybe we can mimic what exists in wp-admin?

[hanneslsm]

Oh wow! I never realized that Trash is used also in wp-admin.
Well, since this seems to have worked for years and hasn't bothered anyone, just ignore what I have said 🙃

Edit:
But, I have to add: The link is red which makes the intention of the action clear. trash is also a verb in english, so it works there. Papierkorb (lit. paper bin) is just a word. So I still think the UX is not ideal, but also can't think of any other solution right now.
However, if the goal of the PR is to save space, we should test if this horizontal layout actually also work in other languages. Was it considered to use same layout for the page actions as in wp-admin, meaning as a second row? I didn't follow the progress.

[hanneslsm]

I was curios and tested the PR in playground and changed the label via inspector.
It can work and I don't think it's a blocker right. Let's continue but we probably might revisit this layout considering other languages and what happens when adding additional actions.