Skip to content

Nav block - conditionally display first horizontal rule if empty placeholder #38031

@getdave

Description

@getdave

In #37884 (comment) @spacedmonkey noted that lower permission users can end up with an empty placeholder. He was concerned about the <hr /> to the right of the block name.

I wonder whether in such circumstances it might be confusing to the user to see an empty block. Should we communicate somehow that this is an expected state due to their permissions and not an error? Some kind of inline message? Open to suggestions.

Would appreciate design input here so pinging @javierarce and @jasmussen who have worked a lot on the block.


This PR looks good. It is a nicpic, not sure it should be part of this PR. But the is a random line here after navigation.
Screenshot 2022-01-17 at 14 46 57

Otherwise this PR looks good.

Originally posted by @spacedmonkey in #37884 (comment)

Metadata

Metadata

Assignees

Labels

Needs DevReady for, and needs developer efforts[Block] NavigationAffects the Navigation Block[Type] EnhancementA suggestion for improvement.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions