Make sure IP addresses can be set properly on the network settings screen

[dkotter]

Description of the Change

Coming out of some changes we made to show a more thorough message around impacts of caching, ran into an issue where IP addresses weren't saving properly on the network settings screen.

Looking into it, the issue was a call to the get_ips method, as this will always pull settings from the site level, not network level.

Now we could update that method to work properly in both situations but in looking at how we were using this method, it seems we use the output of this to decide if we show a more robust caching message, i.e. if someone has IP addresses they've unrestricted, we then show a more robust message.

Unless I'm missing something here, seems fine to show that message to all users, whether they have IP addresses allowed or not. That fixes the problem here and I don't think there's any downside to showing that extra messaging, though I'm open to feedback here.

How to test the Change

1. Network activate RSA
2. Go to the network settings screen and ensure you can add IP addresses, save those and have those persist after a refresh
3. Activate RSA only on the site-level
4. Test the same but at the site-level instead of network level, ensuring things save properly

Changelog Entry

Fixed - Ensure IP addresses can be saved properly at the network level

Credits

Props @dkotter

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added Critical Flows, Test Cases, and/or End-to-End Tests to cover my change.
• All new and existing tests pass.

[peterwilsoncc]

Thanks for catching this, this looks good to me and tests well.