Merge pull request #398 from wp-cli/fix/396-incorrect-success-on-php-requirements-mismatch

Fix counting of errors when attempting activations

Author: swissspidy

features/plugin-activate.feature

@@ -117,7 +117,7 @@ Feature: Activate WordPress plugins
        */
        """
     And I run `wp plugin deactivate --all`
-    And I run `php -r 'echo PHP_VERSION;'`
+    And I run `wp cli info | grep "PHP version" | awk '{print $3}'`
     And save STDOUT as {PHP_VERSION}
 
     When I try `wp plugin activate high-requirements`
@@ -129,6 +129,10 @@ Feature: Activate WordPress plugins
       """
       1 out of 1
       """
+    And STDOUT should not contain:
+      """
+      Success:
+      """
 
   Scenario: Adding --exclude with plugin activate --all should exclude the plugins specified via --exclude
     When I try `wp plugin activate --all --exclude=hello`

src/Plugin_Command.php

@@ -368,6 +368,7 @@ public function activate( $args, $assoc_args = array() ) {
 				$message = wp_strip_all_tags( $message );
 				$message = str_replace( 'Error: ', '', $message );
 				WP_CLI::warning( "Failed to activate plugin. {$message}" );
+				++$errors;
 			} else {
 				$this->active_output( $plugin->name, $plugin->file, $network_wide, 'activate' );
 				++$successes;