Commit 1817e45
authored
Add
## Motivation for the change, related issues
Our SQLite builds don't set the `SQLITE_ENABLE_COLUMN_METADATA` flag,
which results in some metadata missing when
[`PDOStatement::getColumnMeta`](https://www.php.net/manual/en/pdostatement.getcolumnmeta.php)
is used. This results in issues like missing row editing controls in
phpMyAdmin and possibly other problems.
This flag seems to be set in most libsqlite3 builds:
https://www.rogerbinns.com/blog/sqlite-configuration.html
Therefore, I think it's safe to add it and, from the SQLite side, assume
that it's always used.
## Implementation details
I added the flag, updated SQLite, rebuilt it, and rebuilt all PHP
builds.
## Testing Instructions (or ideally a Blueprint)
I added tests for the `SQLITE_ENABLE_COLUMN_METADATA` and they need to
pass.SQLITE_ENABLE_COLUMN_METADATA and update SQLite (#2948)1 parent 8232be3 commit 1817e45
File tree
85 files changed
+3804
-1642
lines changed- packages/php-wasm
- compile/libsqlite3
- asyncify/dist/root/lib
- include
- lib
- pkgconfig
- jspi/dist/root/lib
- include
- lib
- pkgconfig
- node
- asyncify
- 7_2_34
- 7_3_33
- 7_4_33
- 8_0_30
- 8_1_33
- 8_2_29
- 8_3_28
- 8_4_15
- jspi
- 7_2_34
- 7_3_33
- 7_4_33
- 8_0_30
- 8_1_33
- 8_2_29
- 8_3_28
- 8_4_15
- src/test
- web/public/php
- asyncify
- 7_2_34
- 7_3_33
- 7_4_33
- 8_0_30
- 8_1_33
- 8_2_29
- 8_3_28
- 8_4_15
- jspi
- 7_2_34
- 7_3_33
- 7_4_33
- 8_0_30
- 8_1_33
- 8_2_29
- 8_3_28
- 8_4_15
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
85 files changed
+3804
-1642
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
20 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | | - | |
25 | | - | |
| 25 | + | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
Lines changed: 1530 additions & 456 deletions
Large diffs are not rendered by default.
Lines changed: 25 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
359 | 359 | | |
360 | 360 | | |
361 | 361 | | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
362 | 375 | | |
363 | 376 | | |
364 | 377 | | |
| |||
685 | 698 | | |
686 | 699 | | |
687 | 700 | | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
688 | 713 | | |
689 | 714 | | |
690 | 715 | | |
| |||
Binary file not shown.
Lines changed: 0 additions & 41 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Binary file not shown.
Binary file not shown.
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
0 commit comments