Options, Meta APIs: Revert additional request validity handling that was added to the /wp/v2/settings REST API route. This change needs more work to account for URL query parameters used in place of body data.

This reverts [60357] and [60301].

See #41604

git-svn-id: https://develop.svn.wordpress.org/trunk@61324 602fd350-edb4-49c9-b593-d223f7449a82

Author: johnbillion

src/wp-includes/rest-api/endpoints/class-wp-rest-settings-controller.php

@@ -145,19 +145,7 @@ protected function prepare_value( $value, $schema ) {
 	public function update_item( $request ) {
 		$options = $this->get_registered_options();
 
-		$params = array_diff_key( $request->get_params(), $request->get_query_params() );
-
-		if ( empty( $params ) || ! empty( array_diff_key( $params, $options ) ) ) {
-			$message = empty( $params )
-				? __( 'Request body cannot be empty.' )
-				: __( 'Invalid parameter(s) provided.' );
-
-			return new WP_Error(
-				'rest_invalid_param',
-				$message,
-				array( 'status' => 400 )
-			);
-		}
+		$params = $request->get_params();
 
 		foreach ( $options as $name => $args ) {
 			if ( ! array_key_exists( $name, $params ) ) {

tests/phpunit/tests/rest-api/rest-settings-controller.php

@@ -385,24 +385,14 @@ public function test_get_item_with_invalid_object_array_in_options() {
 	}
 
 	/**
-	 * Settings can't be created
+	 * @doesNotPerformAssertions
 	 */
 	public function test_create_item() {
-		wp_set_current_user( self::$administrator );
-
-		$request = new WP_REST_Request( 'POST', '/wp/v2/settings' );
-		$request->set_param( 'new_setting', 'New value' );
-		$response = rest_get_server()->dispatch( $request );
-
-		$this->assertSame( 400, $response->get_status() );
+		// Controller does not implement create_item().
 	}
 
-	/**
-	 * @ticket 41604
-	 */
 	public function test_update_item() {
 		wp_set_current_user( self::$administrator );
-
 		$request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
 		$request->set_param( 'title', 'The new title!' );
 		$response = rest_get_server()->dispatch( $request );
@@ -413,63 +403,6 @@ public function test_update_item() {
 		$this->assertSame( get_option( 'blogname' ), $data['title'] );
 	}
 
-	/**
-	 * @ticket 41604
-	 */
-	public function test_update_item_with_global_parameters_present() {
-		wp_set_current_user( self::$administrator );
-
-		$request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
-		$request->set_param( 'title', 'The new title!' );
-		$request->set_url_params( array( '_locale' => 'user' ) );
-		$response = rest_get_server()->dispatch( $request );
-		$data     = $response->get_data();
-
-		$this->assertSame( 200, $response->get_status() );
-		$this->assertSame( 'The new title!', $data['title'] );
-		$this->assertSame( get_option( 'blogname' ), $data['title'] );
-	}
-
-	/**
-	 * @ticket 41604
-	 */
-	public function test_update_item_with_empty_body() {
-		wp_set_current_user( self::$administrator );
-
-		$request  = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
-		$response = rest_get_server()->dispatch( $request );
-		$data     = $response->get_data();
-
-		$this->assertSame( 400, $response->get_status() );
-	}
-
-	/**
-	 * @ticket 41604
-	 */
-	public function test_update_nonexistent_item() {
-		wp_set_current_user( self::$administrator );
-
-		$request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
-		$request->set_param( 'i_do_no_exist', 'New value' );
-		$response = rest_get_server()->dispatch( $request );
-
-		$this->assertSame( 400, $response->get_status() );
-	}
-
-	/**
-	 * @ticket 41604
-	 */
-	public function test_update_partially_valid_items() {
-		wp_set_current_user( self::$administrator );
-
-		$request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
-		$request->set_param( 'title', 'The new title!' );
-		$request->set_param( 'i_do_no_exist', 'New value' );
-		$response = rest_get_server()->dispatch( $request );
-
-		$this->assertSame( 400, $response->get_status() );
-	}
-
 	public function update_setting_custom_callback( $result, $name, $value, $args ) {
 		if ( 'title' === $name && 'The new title!' === $value ) {
 			// Do not allow changing the title in this case.