-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Open
Labels
Mobile App - i.e. Android or iOSNative mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
Description
Splitting this out from #63081
#63081 adds a new Stylelint custom rule to prevent the usage of the flex-direction CSS property values row-reverse and column-reverse values.
For more details about why this is a problem for accessibility and the very limited cases where these values can be used, please see #63048 and #61241
Contributors working on the native files may want to consider to refactor a few components where row-reverse and column-reverse are currently in use:
- 1 occurrence in
packages/block-editor/src/hooks/use-editor-wrapper-styles.native.scss - 2 occurrences in
packages/block-library/src/media-text/style.native.scss
For mow, #63081 adds Stylelint disable comments. However, if the current implementation actually alters the order in a way that impacts meaning and interaction, it should be refactored.
Cc @WordPress/native-mobile
Step-by-step reproduction instructions
N/A
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
dcalhoun
Metadata
Metadata
Assignees
Labels
Mobile App - i.e. Android or iOSNative mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended