Performance: Only load dashicons when the pledge teams block is rendered

ryelle · ryelle · commit dab5cc0c2d2a · 2024-09-12T11:41:39.000-04:00
diff --git a/themes/wporg-5ftf-2024/functions.php b/themes/wporg-5ftf-2024/functions.php
@@ -44,7 +44,7 @@ function enqueue_assets() {
 	wp_enqueue_style(
 		'wporg-5ftf-2024',
 		get_theme_file_uri( 'build/style/style-index.css' ),
-		array( 'wporg-parent-2021-style', 'wporg-global-fonts', 'dashicons' ),
+		array( 'wporg-parent-2021-style', 'wporg-global-fonts' ),
 		$metadata['version']
 	);
 }
diff --git a/themes/wporg-5ftf-2024/src/pledge-teams/block.json b/themes/wporg-5ftf-2024/src/pledge-teams/block.json
@@ -13,6 +13,6 @@
 	},
 	"usesContext": [ "postId", "postType" ],
 	"editorScript": "file:./index.js",
-	"style": "file:./style-index.css",
+	"style": [ "dashicons", "file:./style-index.css" ],
 	"render": "file:./render.php"
 }

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ function enqueue_assets() {`
`44`	`44`	`wp_enqueue_style(`
`45`	`45`	`'wporg-5ftf-2024',`
`46`	`46`	`get_theme_file_uri( 'build/style/style-index.css' ),`
`47`		`- array( 'wporg-parent-2021-style', 'wporg-global-fonts', 'dashicons' ),`
	`47`	`+ array( 'wporg-parent-2021-style', 'wporg-global-fonts' ),`
`48`	`48`	`$metadata['version']`
`49`	`49`	`);`
`50`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,6 @@`
`13`	`13`	`},`
`14`	`14`	`"usesContext": [ "postId", "postType" ],`
`15`	`15`	`"editorScript": "file:./index.js",`
`16`		`- "style": "file:./style-index.css",`
	`16`	`+ "style": [ "dashicons", "file:./style-index.css" ],`
`17`	`17`	`"render": "file:./render.php"`
`18`	`18`	`}`