2.1: When/why is dark mode enabled?

  • Resolved mrwweb

    (@mrwweb)


    6 months, 4 weeks ago

    With the update to 2.1, it appears that Dark Mode is enabled when the Sucuri Cloudproxy API key is set!?

    From /sucuri-scanner/src/interface.lib.php line 373:

    public static function shouldUseDarkTheme() {

            $api_key = SucuriScanFirewall::getOption(‘:cloudproxy_apikey’);

            return SucuriScanFirewall::isValidKey($api_key);

    }

    I don’t want the dark mode styles or at least would like to be able to turn them off electively, but I don’t see how to do that nor does this logic make much sense to me.

    1. When is dark mode turned on?
    2. How can I turn it off / control it?
Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Support sucuri1

    (@sucuri1)

    6 months, 4 weeks ago

    @mrwweb Thank you for the feedback. Currently dark theme is enabled whenever a firewall key is set in the plugin. We’ve passed this to our engineering team to work on so you can have the option to turn this off and on.

    Thread Starter mrwweb

    (@mrwweb)

    6 months, 4 weeks ago

    @sucuri1 Thanks for the quick response and confirming that what I was seeing was, in fact, intended.

    This setup is strange enough that I assumed this must have been a bug. Dark mode is a highly personal user preference to the point that it can be both improve and worsen the accessibility of an interface depending on the person (some folks need bright high contrast while others can have symptoms triggered by bright lights).

    If there’s a big need to show the status of the firewall, it would be fabulous to create some kind of clearly, prominent, piece of user interface.

    As it stands now, this was extremely confusing—I can’t overstate how confusing it was—and doesn’t align with any expectation I have of how interfaces and user preferences work. It’s fine to present it as an option, but even then, I would mostly expect that it match the entire WordPress interface which is always in light mode.

    kunstwirt

    (@kunstwirt)

    6 months, 3 weeks ago

    @mrwweb – I totally agree.

    @sucuri1 – please fix this, for me ‘dark mode’ is a big accessibility issue.

    Thank you.

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘2.1: When/why is dark mode enabled?’ is closed to new replies.