Reports: Allow meta data about audits in response object #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the report result from each audit to be an object, instead of an array of arrays. This way, we can set some meta properties on each report, and avoid tying the HTML templates to the audits so tightly.
This will now use the
report.namein each section's<h2>. Iftemplateis set (it's optional), the corresponding file intemplates/audits/will be used to render this section. We can also re-use audit templates if the same layout will work for other audits, for example the display-none audit and selectors audit can both use the "selectors" template, since they both display a selector/file combo.To test:
Run the audits. Replace
test.csswith your local test file(s).CLI
JSON
HTML