Skip to content
This repository was archived by the owner on Apr 25, 2024. It is now read-only.

Conversation

@dhruvkb
Copy link
Contributor

@dhruvkb dhruvkb commented Jun 24, 2019

This is a long term PR that tracks the integration of CC Vocabulary into CC Search, component by component. This PR will enable real-time tracking as more and more components are developed and refined in CC Vocabulary and then plugged into the CC Search UI.

Developer Certificate of Origin Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

@dhruvkb
Copy link
Contributor Author

dhruvkb commented Jun 24, 2019

Screenshots of the CC Vocabulary header on CC Search:
Desktop:
image
Phone:
image

@dhruvkb
Copy link
Contributor Author

dhruvkb commented Jun 24, 2019

Screenshots of the CC Vocabulary footer on CC Search:
image
Note that the fonts are being messed up by Foundation CSS. The end goal is to rid CC Search of Foundation when CC Vocabulary subsumes all its functionality.

@kgodey kgodey added this to the Q3 Sprint 4 milestone Jul 11, 2019
@dhruvkb
Copy link
Contributor Author

dhruvkb commented Aug 15, 2019

@brenoferreira It'd be very helpful if you could have clone this branch and provide feedback on the redesign. I had to take a few liberties along the way which I'm not sure about.

dhruvkb added 22 commits August 27, 2019 11:03
…phone, tablet (portrait), tablet (landscape), desktop and big desktop respectively
@annatuma
Copy link

@dhruvkb please let us know what the status of this ticket is, if you have any blockers to moving this forward, etc. We'd love to help get this to completion.

@dhruvkb
Copy link
Contributor Author

dhruvkb commented Oct 18, 2019

@annatuma this has been blocked because of a presentational conflict with Foundation because Vocabulary typography and spacing is being overridden by the site-wide Foundation CSS. Also I've not been able to manage time between Vocabulary stewardship and working on this. If this is still high on priority, I'll try to make time for this.

@brenoferreira
Copy link
Contributor

This is out of date and not relevant anymore

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants