-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Customize: Add label for hue control and improve accessibility #8893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Customize: Add label for hue control and improve accessibility #8893
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @mleray. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
I tested the changes as mentioned by @afercia on the ticket and found the first three points to be addressed. About the 4th point (the hidden input field should not be hidden, and should be used as an alternative way to enter a hue value), I think it makes sense to provide an alternative way to manipulate the values. But I think @joedolson would be a better judge for that. |
|
Do we need to update other themes as well? It seems that Twenty Nineteen for example also has a hue customizer |
|
@mleray Yes, other instances without labels also need to be fixed. I've added changes for Twenty Nineteen and Twenty Twenty; all other core instances already pass the |
|
@himanshupathak95 I think we should commit this without worrying about hidden input. Given that the issue has been open on the Iris repository for 8 years, I don't think it's likely that will be updated any time soon. |
Trac ticket: #42078
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.