Skip to content

Conversation

@SainathPoojary
Copy link

Trac ticket: #42078


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @mleray.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sainathpoojary, joedolson, abcd95.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@himanshupathak95
Copy link

I tested the changes as mentioned by @afercia on the ticket and found the first three points to be addressed.

About the 4th point (the hidden input field should not be hidden, and should be used as an alternative way to enter a hue value), I think it makes sense to provide an alternative way to manipulate the values.

But I think @joedolson would be a better judge for that.

@mleray
Copy link

mleray commented Jun 5, 2025

Do we need to update other themes as well? It seems that Twenty Nineteen for example also has a hue customizer

@joedolson
Copy link
Contributor

@mleray Yes, other instances without labels also need to be fixed. I've added changes for Twenty Nineteen and Twenty Twenty; all other core instances already pass the label parameter.

@joedolson
Copy link
Contributor

@himanshupathak95 I think we should commit this without worrying about hidden input. Given that the issue has been open on the Iris repository for 8 years, I don't think it's likely that will be updated any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants