-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Non-unique names for inputs in nav-menu #8296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| function wp_nav_menu_item_link_meta_box() { | ||
| global $_nav_menu_placeholder, $nav_menu_selected_id; | ||
|
|
||
| $_nav_menu_placeholder = 0 > $_nav_menu_placeholder ? $_nav_menu_placeholder - 1 : -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other places in core code base it use same method do we needs to update those also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 Thanks for the feedback. You're right - I found another instance of the same placeholder generation method in wp-admin/includes/class-walker-nav-menu-checklist.php that could contribute to the non-unique name issue.
I've updated my PR to address both locations with the same consistent approach using a static counter that ensures uniqueness.
This PR fixes an issue where custom menu items in the WordPress navigation menu were being generated with duplicate input names, causing potential form submission and processing issues.
I've tested this with various menu configurations including regular menu items, custom links, and items added through plugins, and the issue with duplicate name attributes no longer occurs.
Let me know if you'd like me to make any adjustments to this approach or if you see any other instances I may have missed.
Trac ticket: https://core.trac.wordpress.org/ticket/62925
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.