Skip to content

Conversation

@snehapatil2001
Copy link

@snehapatil2001 snehapatil2001 commented Feb 11, 2025

This PR fixes an issue where custom menu items in the WordPress navigation menu were being generated with duplicate input names, causing potential form submission and processing issues.

  • Uses a static counter starting from 1000.
  • Increments this counter for each new placeholder.
  • Ensures that even when multiple menu items are added simultaneously, each gets a unique identifier.

I've tested this with various menu configurations including regular menu items, custom links, and items added through plugins, and the issue with duplicate name attributes no longer occurs.

Let me know if you'd like me to make any adjustments to this approach or if you see any other instances I may have missed.

Trac ticket: https://core.trac.wordpress.org/ticket/62925


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Feb 11, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props snehapatil02, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

function wp_nav_menu_item_link_meta_box() {
global $_nav_menu_placeholder, $nav_menu_selected_id;

$_nav_menu_placeholder = 0 > $_nav_menu_placeholder ? $_nav_menu_placeholder - 1 : -1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other places in core code base it use same method do we needs to update those also?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Thanks for the feedback. You're right - I found another instance of the same placeholder generation method in wp-admin/includes/class-walker-nav-menu-checklist.php that could contribute to the non-unique name issue.

I've updated my PR to address both locations with the same consistent approach using a static counter that ensures uniqueness.

@snehapatil2001 snehapatil2001 changed the title Fix: Generate a unique ID instead of using negative numbers. Non-unique names for inputs in nav-menu Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants