Skip to content

Conversation

@rishishah-multidots
Copy link

Pull Request Description

Title: Allow Avatar URL for Custom Comment Type in Comment API

Overview:

This PR introduces a new feature that enables the inclusion of an avatar URL for custom comment types in the WordPress Comment API. This enhancement allows developers to specify custom avatar URLs, improving the flexibility and usability of the comment system for custom comment types.

Changes Made:

  • Updated the Comment API to accept an avatar_url parameter for custom comment types.

Why This Matters:

  • If any custom comment type is passed on comment API then avatar URLs is not fetching so need to add support avatar URLs for custom comment type.

Related Tickets:

Ticket: #60622: Discussion on block comments feature.

@github-actions
Copy link

github-actions bot commented Oct 4, 2024

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Oct 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rishishah, ellatrix.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Oct 4, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

* @param array $types An array of content types.
*/
$allowed_comment_types = apply_filters( 'get_avatar_comment_types', array( 'comment' ) );
$allowed_comment_types = apply_filters( 'get_avatar_comment_types', array( '' ) );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need modification at all? We're already filtering it in the GB PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we generated the comment types PR, this modification ensures consistency and helps prevent potential issues in the future.

made changes for the avatar url in the get comment rest API test cases.
… comment API

made changes to allow custom comment type to fetch avatar URLs in the comment API
@t-hamano
Copy link
Contributor

t-hamano commented Aug 7, 2025

The Block-level comments functionality is still an experimental feature in the Gutenberg plugin, so there's no need to backport it to core. In fact, the backport changelog has been removed.

WordPress/gutenberg#68846

I'm sorry, but let me close this PR. We need to continue to iterate on the Gutenberg plugin and create a backport PR once we have decided to "stabilize" the feature.

@t-hamano t-hamano closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants