-
Notifications
You must be signed in to change notification settings - Fork 3.2k
allow custom comment type to fetch avatar urls in comment api #7498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow custom comment type to fetch avatar urls in comment api #7498
Conversation
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
src/wp-includes/link-template.php
Outdated
| * @param array $types An array of content types. | ||
| */ | ||
| $allowed_comment_types = apply_filters( 'get_avatar_comment_types', array( 'comment' ) ); | ||
| $allowed_comment_types = apply_filters( 'get_avatar_comment_types', array( '' ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need modification at all? We're already filtering it in the GB PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we generated the comment types PR, this modification ensures consistency and helps prevent potential issues in the future.
made changes for the avatar url in the get comment rest API test cases.
… comment API made changes to allow custom comment type to fetch avatar URLs in the comment API
|
The Block-level comments functionality is still an experimental feature in the Gutenberg plugin, so there's no need to backport it to core. In fact, the backport changelog has been removed. I'm sorry, but let me close this PR. We need to continue to iterate on the Gutenberg plugin and create a backport PR once we have decided to "stabilize" the feature. |
Pull Request Description
Title: Allow Avatar URL for Custom Comment Type in Comment API
Overview:
This PR introduces a new feature that enables the inclusion of an avatar URL for custom comment types in the WordPress Comment API. This enhancement allows developers to specify custom avatar URLs, improving the flexibility and usability of the comment system for custom comment types.
Changes Made:
Why This Matters:
Related Tickets:
Ticket: #60622: Discussion on block comments feature.