Skip to content

Conversation

@tirth-doshi-techno
Copy link

I've added a notice in Site Health if the revision is disabled.

If the revision is disabled

Screenshot from 2024-10-02 18-35-05

If the revision is enabled

Screenshot from 2024-10-02 18-34-38

Trac ticket: (https://core.trac.wordpress.org/ticket/62119)

@github-actions
Copy link

github-actions bot commented Oct 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props tirth03.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Oct 2, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment on lines +732 to +748
'label' => __( 'Post Revisions' ),
'status' => $revisions_disabled ? 'recommended' : 'good',
'badge' => array(
'label' => __( 'Content Management' ),
'color' => $revisions_disabled ? 'red' : 'green',
),
'description' => $revisions_disabled
? __( 'Post revisions are currently disabled on your site. It is recommended to enable them to track changes and recover previous versions of your content.' )
: __( 'Post revisions are enabled on your site. This helps with version control and content management.' ),
'actions' => $revisions_disabled
? sprintf(
'<p><a href="%s" target="_blank">%s</a></p>',
esc_url( 'https://wordpress.org/support/article/revisions/' ),
__( 'Learn more about enabling post revisions in WordPress.' )
)
: '',
'test' => 'revisions_status',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation of the => on first level look wrong to me (WPCS issue)

),
'description' => $revisions_disabled
? __( 'Post revisions are currently disabled on your site. It is recommended to enable them to track changes and recover previous versions of your content.' )
: __( 'Post revisions are enabled on your site. This helps with version control and content management.' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually show the revision count here as well.

Knowing that there are plugins out in the wild, that provide different review counts for different Post types, I think it would be reasonable to either try to show this automatically, or at least provide a filter and encourage the use of this for plugin authors.

}

/**
* Tests if the revision is on/off.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Tests if the revision is on/off.
* Tests if revisions are enabled.

*
* @since 6.7.0
*
* @return array The revision results.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @return array The revision results.
* @return array The test results.

To be in sync with other functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants