Skip to content

Conversation

@snehapatil2001
Copy link

This PR enhances the accessibility of comment reply links by synchronizing the visible text and the aria-label attribute. This resolves issues where elements with visible text labels did not have matching accessible names.

Changes

  • Added the use_reply_to_text parameter to the $args array with a default value of false.
  • Updated the function documentation to include descriptions for reply_to_text and use_reply_to_text.
  • Modified the link generation logic to use reply_to_text as the visible text when use_reply_to_text is true.
  • Removed the aria-label when it would be redundant (i.e., when use_reply_to_text is true).
  • Ensured consistent use of double quotes in HTML attributes.

Trac ticket: https://core.trac.wordpress.org/ticket/59965


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Aug 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props snehapatil02, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Aug 5, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

I gave a few suggestions.

snehapatil2001 and others added 3 commits August 6, 2024 11:03
…n and Twenty Seventeen

Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
@joedolson
Copy link
Contributor

In r59181

@joedolson joedolson closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants