Skip to content

Conversation

@Rajinsharwar
Copy link

Adding ESI in the allowed HTML list

Trac ticket: https://core.trac.wordpress.org/ticket/58921


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@alewolf
Copy link

alewolf commented Jul 28, 2023

This patch doesn't work and won't solve the issue. It doesn't allow the full tag name which is esi:include.

And adding esi:include to that allow list won't work either. It get's ignored because of the colon somehow.

@martinkrcho
Copy link

@Rajinsharwar have a look at the approach implemented in #4929, please.

Would you also please close this pull request? Thank you

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @alewolf.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rajinsharwar, martinkrcho.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants