Coding Standards: Use more meaningful variable names in Admin AJAX actions. #3198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
427b7bc to
b50eed1
Compare
added 20 commits
September 6, 2022 00:28
…ax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…es/ajax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…ax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…/ajax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…ax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…/includes/ajax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…ludes/ajax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…des/ajax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…ncludes/ajax-actions.php`. Per naming conventions, separate words via underscores.
…ncludes/ajax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…jax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…/ajax-actions.php`. As this is not used for an image's `alt` attribute, using an abbreviation here creates ambiguity. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…ax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…jax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…des/ajax-actions.php`. Per naming conventions, separate words via underscores.
…/ajax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…n/includes/ajax-actions.php`. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
…es/ajax-actions.php`. Per naming conventions, use lowercase letters in variable, action/filter, and function names (never camelCase).
…actions.php`. Note: This variable is initialized to `0` and used only once. Normally, the value would be passed directly at the point of usage. However, this variable is passed to `_list_meta_row()`, which accepts the `$count` argument by reference. Only variables can be passed by reference. Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
b50eed1 to
18ad209
Compare
Member
|
Thanks for the PR! Merged in r61224. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.
See PHP Coding Standards - Naming Conventions.
This PR includes renaming of the following variables:
$post_IDto$post_id. - "Use lowercase letters in variable, action/filter, and function names"$ext_typeto$extension_type.$extto$extension.$id3datato$id3_data. - "Separate words via underscores."$msgto$message.$sbto$sidebar.$altto$alternate.$pidto$post_id.$menu_objto$menu_object.$noparentsto$no_parents. - "Separate words via underscores."$supto$supplemental.$cat_idto$category_id.$cat_nameto$category_name.$outto$output.$rto$edit_result.$tto$taxonomy.$uto$update_result.$rto$result.$responseto$response_data.$xto$response.Trac ticket:
https://core.trac.wordpress.org/ticket/64226
https://core.trac.wordpress.org/ticket/63168
https://core.trac.wordpress.org/ticket/55647