Remove pattern override dropdown from block toolbar icon #73053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This message feels unhelpful and confusing. At one point it may have been more helpful. I can edit the field by interacting with it, so the message is confusing to me.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
commented
Nov 6, 2025
|
|
||
| const isDefaultEditingMode = | ||
| getBlockEditingMode( clientIds[ 0 ] ) === 'default'; | ||
| const _hideTransformsForSections = |
Contributor
Author
There was a problem hiding this comment.
Removed the _ as this is only used when we have a const naming conflict. These aren't exposed from the selector, so we can use the default naming.
| ( hasBlockStyles || canRemove ) && | ||
| ! hasTemplateLock; | ||
|
|
||
| const _showPatternOverrides = hasPatternOverrides && hasParentPattern; |
Contributor
Author
There was a problem hiding this comment.
We don't need this check anymore, as it came after the showBlockSwitcher check anyways
Comment on lines
+49
to
+50
| const showBlockSwitcher = | ||
| ! hideTransformsForSections && |
Contributor
Author
There was a problem hiding this comment.
Same as above, no need for the _ prefix.
| const { getActiveBlockVariation } = select( blocksStore ); | ||
|
|
||
| const _isSingleBlock = clientIds.length === 1; | ||
| const isSingleBlock = clientIds.length === 1; |
| const blockType = getBlockType( blockName ); | ||
|
|
||
| if ( _isSingleBlock ) { | ||
| if ( isSingleBlock ) { |
|
Size Change: -396 B (-0.02%) Total Size: 2.45 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 48ab96f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19139946619
|
Contributor
I'm curious about this. Can you explain a little more about why it's not helpful? Is it not accurate? Is there a need for some UX explaining what's happening? |
Contributor
Author
|
For updating the message vs removing the message, can we discuss on #73054? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #73054
The Block Toolbar Icon message for synced pattern overrides is not helpful. This PR removes the message.
Why?
UX quality
How?
Removes the component, file, and related tests.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast