Test: collab-sidebar perf debugging #72757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -12.8 kB (-0.54%) Total Size: 2.36 MB
ℹ️ View Unchanged
|
Contributor
Author
|
@Mamaduka @t-hamano - Here's the rest of my original comment for posterity. May not be worth the effort right now. I've been looking into it, and it seems like the structure of fetching all notes and building the tree is just going to be expensive. Is there a way we could defer this work until we have a note so the many editor instances with no notes don't need the extra performance overhead? I was trying to at least defer til the notes had been opened once, but I couldn't show the multiple block toolbar avatars without getting the nested threads. The only one that's really necessary when there are zero notes is the "Add note" option in the menu. The majority of posts will not have any notes (at least at first!), so IMO it would be worth some extra complexity to not have the extra work for all blocks if we know there are no notes yet. |
Member
Unfortunately, it's a known bottleneck. We're tracking future improvements in this issue #71668. For now, it's best to avoid major refactoring to prevent backport conflicts, but that's definitely on the roadmap for WP 7.0.
The data hook shouldn't perform any work if the REST API returns no notes, but I think we can be more strict about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There are some indicators in the code vitals that the collab sidebar could be impacting performance, so I'm just excluding it to see if any numbers go down. If they do, it would be worth looking into what and why.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast