Block Bindings: Only show in the UI for sourced attributes. #72663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +8 B (0%) Total Size: 2.27 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0a7c6dd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18779364910
|
Contributor
Author
|
Closing in favor of #72716 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Do not review - test it yet. Is a proof of concept of a possible solution to all the side effects of adding bindings to both
post-dateandnavigation-linkitems on the UI.This solution may be cleaner than hardcoding a list of blocks that want to hide the UI.
I will present a new attribute option in another PR.
Caveats.
sourcewas not meant to be related to the bindings UI, but is true that they define how the attribute values are extracted from saved post content.imageblockiddisappears from the UI. (It is not a widely bound attribute that requires ID in my opinion, as the image should bind with all the attributes together to the same source.