Skip to content

Conversation

@sirreal
Copy link
Member

@sirreal sirreal commented Sep 23, 2025

What?

Add JSON schema checking to CI. This should help prevent issues appearing in schemas in the repo.

This has #71852 merged to fix existing issues.

Closes #71817.

Why?

It's good to prevent schema errors in the files in the repo. See #71800 for an example.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano
Copy link
Contributor

Thanks for the PR.

How about adding unit tests instead of CI? This is because there are already unit tests that check the theme.json and wp-env.json schemas.

@sirreal
Copy link
Member Author

sirreal commented Sep 24, 2025

👌 I didn't realize there were already unit tests for JSON schema validation.

@sirreal sirreal closed this Sep 24, 2025
@sirreal sirreal deleted the add/check-json-schema-ci branch September 24, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build/test tooling: Check json schema conformance for block.json and theme.json

3 participants