Skip to content

Conversation

@shail-mehta
Copy link
Member

What?

Closes #71788

Why? How ?

  • Modifies the script for the category widget dropdown select to prevent esc from submitting

Testing Instructions

  1. Add a block Category list(Term List) widget.
  2. Set as dropdown mode.
  3. On Windows/Chrome, Windows/Firefox, or Linux/Chromium, open the select from the keyboard, use the arrow key to navigate, then use esc to close.

@shail-mehta shail-mehta self-assigned this Sep 22, 2025
@shail-mehta shail-mehta added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets labels Sep 22, 2025
@shail-mehta shail-mehta marked this pull request as ready for review September 22, 2025 18:07
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Flaky tests detected in b7be808.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17923772142
📝 Reported issues:

Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shail-mehta! The related code in core has undergone significant changes in https://github.com/WordPress/wordpress-develop/pull/9810/files; can you update this to match?

I'd also like to see the code for the archives widget included in this: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/archives/index.php.

@joedolson
Copy link
Contributor

The conflicts with this PR are basically the entirety of the PR at this point, since there have been significant changes to the category widget JS since this was started. So I'm going to go ahead and start a new PR to resolve this issue.

@joedolson
Copy link
Contributor

Closing, made obsolete by e2547a7

@joedolson joedolson closed this Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent esc from executing the change event in archive widget dropdowns

3 participants