-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Prevent Esc from executing change event in Category Widget #71824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in b7be808. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17923772142
|
joedolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @shail-mehta! The related code in core has undergone significant changes in https://github.com/WordPress/wordpress-develop/pull/9810/files; can you update this to match?
I'd also like to see the code for the archives widget included in this: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/archives/index.php.
|
The conflicts with this PR are basically the entirety of the PR at this point, since there have been significant changes to the category widget JS since this was started. So I'm going to go ahead and start a new PR to resolve this issue. |
|
Closing, made obsolete by e2547a7 |
What?
Closes #71788
Why? How ?
Testing Instructions