-
Notifications
You must be signed in to change notification settings - Fork 4.6k
element: Make createInterpolateElement TS/type smart #71513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
element: Make createInterpolateElement TS/type smart #71513
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1 B (0%) Total Size: 2.45 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in afc7264. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18304055943
|
What?
This PR makes
createInterpolateElementtype/TS smart by interpolating the string passed as the first argument and then providing type-checking for theconversionMapprovided as the second argumentWhy?
To enhance type-safety and allow auto-completions for
createInterpolateElementHow?
The PR uses some advanced TypeScrip string interpolation to create types like
ConversionMapwhich uses another typeExtractTagswhich extracts tags from the passed string. The types are commented enough to make them readable and maintainableTesting Instructions
Testing Instructions for Keyboard
Screenshots or screencast