Skip to content

Conversation

@dhruvikpatel18
Copy link
Contributor

@dhruvikpatel18 dhruvikpatel18 commented Mar 25, 2025

Closes #60982

What?

Fix Footnotes block editing in sync patterns

Why?

Currently, when a Footnotes block is added to a Sync Pattern, users cannot edit the footnotes from either the Post/Page content or the Pattern editor. This significantly limits the usability of footnotes in reusable patterns.

Testing Instructions

  1. Create a new page or post
  2. Add a Footnotes block to your content
  3. Create a Group block containing the Footnotes block
  4. Convert the Group block to a Sync Pattern
  5. Verify you can edit footnotes:
    • In the original post/page
    • In the Sync Pattern
    • In other posts using the same pattern

Screenshots or screencast

Before

FootnotesBefore.mov

After

FootnotesAfter.mov

@dhruvikpatel18 dhruvikpatel18 force-pushed the fix/footnotes-sync-pattern-editing branch from cb12ef5 to 9baa31e Compare March 26, 2025 07:31
@dhruvikpatel18 dhruvikpatel18 marked this pull request as ready for review March 26, 2025 10:17
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @druxstr.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: druxstr.

Co-authored-by: dhruvikpatel18 <dhruvik18@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Block] Footnotes Affects the Footnotes Block labels Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Footnotes Affects the Footnotes Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Footnotes in sync patterns can't be edited

2 participants