Move block toolbar check to before rendering the block toolbar #60480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
Member
|
@jeryj, should we close this? |
Contributor
Author
|
The PR seems like it should be a performance improvement. I'm not sure it ends up being a performance improvement in practice though. I'm fine closing it though. |
Member
|
@jeryj, I'll try to rebase and retest it. P.S. I'm going through some old PRs and mostly checking what can be closed. Thanks for the reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Trying to improve performance of block toolbar.
Why?
🏇🏻
How?
There's a check within block toolbar for
hasBlockToolbarthat happens after a useSelect. IfhasBlockToolbaris false, we know we won't show the toolbar, so there's no reason to make auseSelectafterwards. However, I don't think this will speed up anything for block toolbars that do render, just for the times where there is no block toolbar.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast